Feat/modularize #407
Merged
Feat/modularize #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supporting data request callbacks
Tommytrg
reviewed
Feb 16, 2024
.github/workflows/npm-publish.yml
Outdated
Comment on lines
14
to
18
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18 | ||
| registry-url: https://registry.npmjs.org/ |
There was a problem hiding this comment.
Suggested change
| - uses: actions/checkout@v3 | |
| - uses: actions/setup-node@v3 | |
| with: | |
| node-version: 18 | |
| registry-url: https://registry.npmjs.org/ | |
| - uses: actions/checkout@v4 | |
| - uses: actions/setup-node@v4 | |
| with: | |
| node-version: 20 |
| @@ -4,28 +4,23 @@ | |||
|
|
|||
| pragma solidity >=0.8.0 <0.9.0; | |||
|
|
|||
| import "../patterns/ERC165.sol"; | |||
There was a problem hiding this comment.
We are not using ERC165, could we delete it?
README.md
Outdated
| - **`hash()`**: | ||
| - _Description_: | ||
| - Returns SHA256 hash of Witnet Data Request as CBOR-encoded bytes. | ||
| - Make sure you run an ETH/RPC provider running at the specified `host` and `port`, capable of intercepting `eth_sendTransaction` calls (e.g. [web3-ethrpc-gateway](https://github.io/witnet/web3-jsonrpc-gateway)). |
There was a problem hiding this comment.
Suggested change
| - Make sure you run an ETH/RPC provider running at the specified `host` and `port`, capable of intercepting `eth_sendTransaction` calls (e.g. [web3-ethrpc-gateway](https://github.io/witnet/web3-jsonrpc-gateway)). | |
| - Make sure you run an ETH/RPC provider for the specified `host` and `port`, capable of intercepting `eth_sendTransaction` calls (e.g. [web3-ethrpc-gateway](https://github.io/witnet/web3-jsonrpc-gateway)). |
Comment on lines
+70
to
+73
| "eslint-config-standard": "^17.1.0", | ||
| "eslint-plugin-import": "^2.29.1", | ||
| "eslint-plugin-n": "^16.6.2", | ||
| "eslint-plugin-promise": "^6.1.1", |
There was a problem hiding this comment.
I think we aren't using this eslint files but eslint-config-standard, could we remove the other ones?
package.json
Outdated
| "eth-gas-reporter": "^0.2.27", | ||
| "eth-helpers": "^1.3.0", | ||
| "hardhat": "^2.19.5", | ||
| "js-sha256": "^0.11.0", |
There was a problem hiding this comment.
Are we using this dependency?
Suggested change
| "js-sha256": "^0.11.0", |
package.json
Outdated
| "truffle": "^5.11.5", | ||
| "truffle-assertions": "^0.9.2", | ||
| "truffle-flattener": "^1.6.0", | ||
| "typescript": "latest" |
There was a problem hiding this comment.
Do we have any typescript file?
Suggested change
| "typescript": "latest" |
Tommytrg
reviewed
Feb 16, 2024
scripts/prepare.js
Outdated
| if (os.type() === "Windows_NT") { | ||
| exec("del /s /q artifacts\\*.dbg.json") | ||
| } else { | ||
| exec("find ./artifacts -name *.dbg.json -exec rm -r {} \\;") |
There was a problem hiding this comment.
Suggested change
| exec("find ./artifacts -name *.dbg.json -exec rm -r {} \\;") | |
| exec('find ./artifacts -name "*.dbg.json" -exec rm -r {} \\;') |
| pragma solidity >=0.6.0 <0.9.0; | ||
|
|
||
| import "../interfaces/IERC20.sol"; | ||
| import "@openzeppelin/contracts/token/ERC20/IERC20.sol"; |
There was a problem hiding this comment.
Or if we want to keep a file for each of the contracts from openzeppelin, do the same for IERC20.sol
Tommytrg
reviewed
Feb 19, 2024
|
|
||
| /// @notice Reference to Witnet Data Requests Bytecode Registry | ||
| WitnetBytecodes immutable public override(IWitnetRequestFactory, WitnetRequestTemplate) registry; | ||
| /// @notice Reference to the Witnet Request Board that all templates built out from this factory will refer to. |
There was a problem hiding this comment.
Suggested change
| /// @notice Reference to the Witnet Request Board that all templates built out from this factory will refer to. | |
| /// @notice Reference to the Witnet Request Board that all templates built out from this factory will refer to. |
Tommytrg
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.